Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core issue of 4447 and change declare order for compatibility #4448

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Aug 25, 2020

  1. Fix core bug wild pointer in PlanFragmentExecutor, Fix [Bug] Core problem in query mysql external table if compile BE code disable the complile var WITH_MYSQL #4447
  2. Fix core bug wild pointer json load, Fix [Bug] core problem when load json data, when the jsonpaths not inappropriate with table column #4452
  3. Change the declare order of ODBC type in thrift for compatibility

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

wutiangan
wutiangan previously approved these changes Aug 25, 2020
kangkaisen
kangkaisen previously approved these changes Aug 25, 2020
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Aug 25, 2020
1. Fix core bug wild pointer in PlanFragmentExecutor, fix issue apache#4447
2. Fix core bug wild pointer json load, fix issue apache#4452
3. Change the declare order of ODBC type in thrift for compatibility
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit e4e9af4 into apache:master Aug 26, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
4 participants