[fix](hyperscan) Fix hyper scan fall back to re2 #44547
Merged
+57
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40112 ms |
TPC-DS: Total hot run time: 197785 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.49 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
cambyzju
reviewed
Nov 26, 2024
| @@ -499,9 +496,6 @@ Status FunctionLikeBase::hs_prepare(FunctionContext* context, const char* expres | |||
| hs_free_database(*database); | |||
| *database = nullptr; | |||
| *scratch = nullptr; | |||
| if (context) { | |||
There was a problem hiding this comment.
please leave a comment here, avoid somebody add these codes back again next time.
There was a problem hiding this comment.
OK，I will add some test and comment.
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 39832 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196595 ms |
ClickBench: Total hot run time: 33.84 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
cambyzju
approved these changes
Nov 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Core modification When hyper scan failed, we should not set_error in FunctionContext. Since set_error will try cancel query, but actually we want to fall back to re2 in this case. * Some refactor Rename FunctionRegexp so that we can distinguish regexp match with regexp_extract. * Reproduce ```cpp SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海｜^北京" ORDER BY id; ``` Note, the `|` in above sql is a Chinese character.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Core modification When hyper scan failed, we should not set_error in FunctionContext. Since set_error will try cancel query, but actually we want to fall back to re2 in this case. * Some refactor Rename FunctionRegexp so that we can distinguish regexp match with regexp_extract. * Reproduce ```cpp SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海｜^北京" ORDER BY id; ``` Note, the `|` in above sql is a Chinese character.
yiguolei
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Core modification When hyper scan failed, we should not set_error in FunctionContext. Since set_error will try cancel query, but actually we want to fall back to re2 in this case. * Some refactor Rename FunctionRegexp so that we can distinguish regexp match with regexp_extract. * Reproduce ```cpp SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海｜^北京" ORDER BY id; ``` Note, the `|` in above sql is a Chinese character.
yiguolei
pushed a commit
that referenced
this pull request
Nov 27, 2024
yiguolei
pushed a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Core modification
When hyper scan failed, we should not set_error in FunctionContext.
Since set_error will try cancel query, but actually we want to fall back to re2 in this case.
Some refactor
Rename FunctionRegexp so that we can distinguish regexp match with regexp_extract.
Reproduce
SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海｜^北京" ORDER BY id;Note, the
|in above sql is a Chinese character.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)