[Spark Load] Redirect the spark launcher's log to a separated log file #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Aug 27, 2020
| @@ -103,7 +114,7 @@ public void run() { | |||
| try { | |||
| outReader = new BufferedReader(new InputStreamReader(process.getInputStream())); | |||
| while (!isStop && (line = outReader.readLine()) != null) { | |||
| LOG.info("monitor log: " + line); | |||
| outputBuffer.append(line + '\n'); | |||
There was a problem hiding this comment.
why not just output to the outputStream? So that we don't need to buffer a log of content in memory?
| } | ||
|
|
||
| public void clearSparkLauncherLog() { | ||
| String logPath = sparkLoadAppHandle.getLogPath(); |
There was a problem hiding this comment.
Are you sure the sparkLoadAppHandle is not null here?
There was a problem hiding this comment.
Not sure. So I made a new check here.
morningman
added
area/spark-load
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#4469
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.