Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix bug of select @@sql_mode #4484

Merged
merged 1 commit into from
Sep 1, 2020
Merged

[Bug] Fix bug of select @@sql_mode #4484

merged 1 commit into from
Sep 1, 2020

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Aug 29, 2020 •
edited
Loading

Proposed changes

Fix bug that select @@sql_mode throw error: Invalid number format.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • [] I have create an issue on (Fix connect doris use mysql-driver error #4483), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

Not sure this is a good solution.

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/mysql-compatibility Issues or PRs related to the mysql compatibility labels Aug 29, 2020
yangzhg
yangzhg approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Aug 31, 2020
@morningman morningman merged commit d495661 into apache:master Sep 1, 2020
ZhangYu0123 pushed a commit to ZhangYu0123/incubator-doris that referenced this pull request Sep 1, 2020
@morningman @ZhangYu0123
[Bug] Fix bug of select @@sql_mode (apache#4484)
362ac45 
Fix bug that `select @@sql_mode` throw error: Invalid number format.
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangzhg yangzhg yangzhg approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connect doris use mysql-driver error
2 participants
@morningman @yangzhg