Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark load][Bug] fix that cancelling a spark load in the PENDING phase will not succeed #4536

Merged
merged 5 commits into from
Sep 6, 2020

Conversation

xy720
Copy link
Member

@xy720 xy720 commented Sep 4, 2020

Proposed changes

To Reproduce
Steps to reproduce the behavior:

  1. Submit a spark load job
  2. The job state is PENDDING at the beginning.
  3. cancel load job.
  4. Show load. And you can see the job state is CANCELLED with msg user cancel
  5. Open the web interface of the yarn cluster with browser, you can see that the spark job has been submitted successfully and is running well.

Expected behavior
The spark job should not be submmited.

The reson of this Bug
When a user wants to cancel a loadjob in the pending phase, it is possible that the appId in the SparkLoadJob is empty, causing the yarn command to fail, so we need to get the appId through the handle.

If the appId still cannot be get from handle, which means the spark mission hasn't been submitted, the spark launcher process should be killed to prevent the spark mission from being submitted to yarn cluster.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

@xy720 xy720 changed the title [Spark load][Bug] fix cancelling a spark load in the PENDING phase will not succeed [Spark load][Bug] fix that cancelling a spark load in the PENDING phase will not succeed Sep 4, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/spark-load Issues or PRs related to the spark load kind/fix Categorizes issue or PR as related to a bug. labels Sep 5, 2020
@morningman morningman self-assigned this Sep 5, 2020
@morningman morningman merged commit 8f10317 into apache:master Sep 6, 2020
morningman pushed a commit that referenced this pull request Sep 7, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/spark-load Issues or PRs related to the spark load kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spark Load][Bug] Cancelling a spark load in the pending phase will not succeed
2 participants