Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](inverted index) Fix Null Pointer Exception in function match #45456

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[fix](inverted index) Fix Null Pointer Exception in function match #45456

merged 1 commit into from
Dec 17, 2024

Conversation

zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Dec 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

  1. Using select match_phrase('', '') in the old optimizer causes issues

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/vec/function/function_match_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.82% (10125/26084)
Line Coverage: 29.76% (85077/285899)
Region Coverage: 28.81% (43638/151481)
Branch Coverage: 25.35% (22165/87434)
Coverage Report: http://coverage.selectdb-in.cc/coverage/439ccab01c69b8d9cff76a86db5239806f46c2f5_439ccab01c69b8d9cff76a86db5239806f46c2f5/report/index.html

airborne12
airborne12 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit eb769d4 into apache:master Dec 17, 2024
32 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match (#…
488f198 
…45456)

Problem Summary:

Using select match_phrase('', '') in the old optimizer causes issues
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Merged
@wm1581066 wm1581066 added the usercase Important user case type label label Dec 19, 2024
yiguolei pushed a commit that referenced this pull request Dec 20, 2024
@github-actions @zzzxl1993
branch-3.0: [fix](inverted index) Fix Null Pointer Exception in funct…
d047f23 
…ion match #45456 (#45499)

Cherry-picked from #45456

Co-authored-by: zzzxl <yangsiyu@selectdb.com>
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Dec 23, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match (a…
d9bbce9 
…pache#45456)

Problem Summary:

Using select match_phrase('', '') in the old optimizer causes issues
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Dec 23, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match (a…
c75de83 
…pache#45456)

Problem Summary:

Using select match_phrase('', '') in the old optimizer causes issues
This was referenced Dec 23, 2024
Merged
Closed
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Dec 23, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match (a…
a69dcdf 
…pache#45456)

Problem Summary:

Using select match_phrase('', '') in the old optimizer causes issues
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Dec 23, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match (a…
94635a3 
…pache#45456)

Problem Summary:

Using select match_phrase('', '') in the old optimizer causes issues
qidaye pushed a commit that referenced this pull request Dec 24, 2024
@zzzxl1993
[fix](inverted index) Fix Null Pointer Exception in function match(#4…
02f15a8 
…5456)(#45774)

pick: #45456
@qidaye qidaye removed the dev/2.1.x label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@airborne12 airborne12 airborne12 approved these changes

@qidaye qidaye qidaye approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zzzxl1993 @Thearas @doris-robot @airborne12 @qidaye @yiguolei @wm1581066