Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](auth)Reduce the scope of permission locks #46115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Dec 27, 2024

What problem does this PR solve?

when check table exists, not need hold write lock of Auth
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Reduce the scope of permission locks

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Dec 27, 2024

run buildall

1 similar comment
@zddr
Copy link
Contributor Author

zddr commented Dec 27, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32399 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b26c683bc18f5c8306b3937de0e3d2bd398cf366, data reload: false

------ Round 1 ----------------------------------
q1	17606	6111	5998	5998
q2	2045	312	191	191
q3	10384	1251	727	727
q4	10213	854	428	428
q5	7510	2173	1971	1971
q6	208	183	149	149
q7	890	753	609	609
q8	9242	1348	1153	1153
q9	5161	4879	4879	4879
q10	6746	2333	1889	1889
q11	466	271	251	251
q12	345	347	230	230
q13	17751	3534	2903	2903
q14	230	237	212	212
q15	541	496	493	493
q16	637	620	609	609
q17	582	842	324	324
q18	7240	6405	6491	6405
q19	2314	979	539	539
q20	304	310	190	190
q21	2798	2180	1937	1937
q22	361	326	312	312
Total cold run time: 103574 ms
Total hot run time: 32399 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6276	6288	6241	6241
q2	240	322	238	238
q3	2242	2630	2329	2329
q4	1415	1793	1356	1356
q5	4360	4754	4809	4754
q6	189	181	142	142
q7	2116	1962	1777	1777
q8	2564	2795	2647	2647
q9	7345	7251	7201	7201
q10	3059	3296	2842	2842
q11	592	510	503	503
q12	664	777	628	628
q13	3383	3807	3117	3117
q14	304	308	278	278
q15	559	512	513	512
q16	661	674	625	625
q17	1200	1707	1244	1244
q18	7809	7310	6977	6977
q19	786	1144	1037	1037
q20	1920	1930	1823	1823
q21	5443	5200	4894	4894
q22	597	624	568	568
Total cold run time: 53724 ms
Total hot run time: 51733 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190423 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b26c683bc18f5c8306b3937de0e3d2bd398cf366, data reload: false

query1	986	373	380	373
query2	6523	2320	2366	2320
query3	6740	217	217	217
query4	33636	23981	23433	23433
query5	4361	602	455	455
query6	285	209	197	197
query7	4625	500	307	307
query8	312	273	244	244
query9	9640	2755	2735	2735
query10	476	302	251	251
query11	18280	15847	15400	15400
query12	165	111	107	107
query13	1699	541	419	419
query14	10424	7232	6910	6910
query15	270	199	189	189
query16	8122	572	425	425
query17	1583	747	566	566
query18	2137	401	312	312
query19	269	178	157	157
query20	117	111	108	108
query21	208	119	99	99
query22	4261	4244	4363	4244
query23	34586	33765	33492	33492
query24	6426	2241	2374	2241
query25	509	447	379	379
query26	1084	273	152	152
query27	2021	460	329	329
query28	5224	2443	2425	2425
query29	737	531	414	414
query30	227	179	151	151
query31	967	907	809	809
query32	87	61	83	61
query33	495	359	294	294
query34	741	835	509	509
query35	783	828	733	733
query36	989	1024	954	954
query37	112	98	81	81
query38	4200	4346	4125	4125
query39	1519	1432	1437	1432
query40	211	112	97	97
query41	48	46	46	46
query42	116	107	102	102
query43	510	517	480	480
query44	1293	807	808	807
query45	182	171	169	169
query46	875	1038	648	648
query47	1901	1921	1858	1858
query48	380	403	320	320
query49	761	475	389	389
query50	625	649	384	384
query51	7161	7150	7192	7150
query52	104	98	101	98
query53	217	248	193	193
query54	468	486	392	392
query55	79	80	78	78
query56	247	259	256	256
query57	1210	1164	1134	1134
query58	236	216	229	216
query59	3125	3090	2956	2956
query60	271	271	264	264
query61	111	106	111	106
query62	856	822	725	725
query63	226	188	189	188
query64	4572	978	625	625
query65	3260	3228	3219	3219
query66	1018	413	306	306
query67	16067	15898	15598	15598
query68	9555	754	506	506
query69	492	295	322	295
query70	1223	1143	1154	1143
query71	434	280	241	241
query72	5745	3785	4045	3785
query73	669	741	364	364
query74	10425	9105	9000	9000
query75	4560	3177	2640	2640
query76	5554	1174	814	814
query77	1025	364	270	270
query78	10049	10293	9413	9413
query79	3492	894	610	610
query80	721	513	432	432
query81	468	280	227	227
query82	400	145	124	124
query83	199	165	154	154
query84	284	88	69	69
query85	748	350	310	310
query86	353	329	311	311
query87	4613	4655	4367	4367
query88	3289	2240	2196	2196
query89	422	339	306	306
query90	2071	184	188	184
query91	134	139	105	105
query92	67	59	51	51
query93	2001	882	513	513
query94	660	387	282	282
query95	338	251	251	251
query96	488	610	278	278
query97	2751	2748	2661	2661
query98	216	198	201	198
query99	1664	1583	1470	1470
Total cold run time: 297066 ms
Total hot run time: 190423 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b26c683bc18f5c8306b3937de0e3d2bd398cf366, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.42	0.41	0.40
query6	1.15	0.65	0.66
query7	0.02	0.01	0.02
query8	0.03	0.04	0.04
query9	0.58	0.51	0.52
query10	0.56	0.60	0.56
query11	0.15	0.11	0.12
query12	0.15	0.11	0.11
query13	0.61	0.61	0.59
query14	2.87	2.79	2.77
query15	0.90	0.83	0.82
query16	0.38	0.38	0.38
query17	1.05	1.02	1.09
query18	0.22	0.21	0.20
query19	1.95	1.81	2.03
query20	0.01	0.01	0.01
query21	15.36	0.91	0.58
query22	0.75	0.84	0.61
query23	15.32	1.53	0.57
query24	2.69	1.19	0.96
query25	0.19	0.11	0.21
query26	0.23	0.15	0.13
query27	0.08	0.06	0.05
query28	13.88	1.53	1.05
query29	12.54	3.90	3.22
query30	0.25	0.09	0.07
query31	2.83	0.59	0.39
query32	3.22	0.55	0.45
query33	3.20	3.06	3.01
query34	16.58	5.08	4.51
query35	4.51	4.47	4.48
query36	0.65	0.48	0.48
query37	0.10	0.06	0.05
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.81 s
Total hot run time: 31.22 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants