Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LRUCache] Expose LRU Cache status to metrics #4688

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Sep 29, 2020

Proposed changes

Expose LRU Cache status to metrics would be helpful to diagnose
problems like high usage, low hit rate.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@morningman
Copy link
Contributor

Hi @acelyc111 , thanks for your PR.
And I suggest to add document for new API. Better to place it here:
administrator-guide/http-actions/be/lru-cache-action.md.

You can refer to the content format in administrator-guide/http-actions/fe/connection-action.md

@morningman morningman added api-review Categorizes an issue or PR as actively needing an API review. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 4, 2020
@acelyc111 acelyc111 force-pushed the cache_action branch 2 times, most recently from e620c70 to 84a83c8 Compare October 15, 2020 15:03
@acelyc111
Copy link
Member Author

Please review #4751 at first

@acelyc111 acelyc111 changed the title [LRUCache] Expose LRU Cache status by HTTP API [LRUCache] Expose LRU Cache status to metrics Oct 16, 2020
@acelyc111
Copy link
Member Author

Hi @acelyc111 , thanks for your PR.
And I suggest to add document for new API. Better to place it here:
administrator-guide/http-actions/be/lru-cache-action.md.

You can refer to the content format in administrator-guide/http-actions/fe/connection-action.md

@morningman I've change to expose these status to metric instead of http API, metric is more firendly to third-party monitor system.

Expose LRU Cache status to metrics would be helpful to diagnose
problems like high usage, low hit rate.
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 6cbefd5 into apache:master Oct 22, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants