-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LRUCache] Expose LRU Cache status to metrics #4688
Conversation
Hi @acelyc111 , thanks for your PR. You can refer to the content format in |
e620c70
to
84a83c8
Compare
Please review #4751 at first |
daec43c
to
2b6e569
Compare
@morningman I've change to expose these status to metric instead of http API, metric is more firendly to third-party monitor system. |
Expose LRU Cache status to metrics would be helpful to diagnose problems like high usage, low hit rate.
4ec5a39
to
b337c00
Compare
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Expose LRU Cache status to metrics would be helpful to diagnose
problems like high usage, low hit rate.
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.