Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](coldheat) fix missing partition's storage policy in create_table_like stmt #47145

Open
wants to merge 2 commits into
base: branch-2.0
Choose a base branch
from

Conversation

Yulei-Yang
Copy link
Contributor

bp: #47009

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yulei-Yang
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49438 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ef7bbe55219ddd75cfa4b7552fd53173fa347fff, data reload: false

------ Round 1 ----------------------------------
q1	17644	4444	4379	4379
q2	2070	161	144	144
q3	10310	1907	1951	1907
q4	10102	1270	1352	1270
q5	8416	4038	3864	3864
q6	232	121	129	121
q7	2071	1612	1593	1593
q8	9392	2754	2725	2725
q9	10467	9984	9943	9943
q10	8714	3541	3518	3518
q11	422	241	241	241
q12	473	293	303	293
q13	18360	3981	4045	3981
q14	360	322	334	322
q15	514	463	461	461
q16	537	459	458	458
q17	1151	954	972	954
q18	7317	6927	6877	6877
q19	1683	1598	1602	1598
q20	503	308	309	308
q21	4386	4196	4091	4091
q22	501	396	390	390
Total cold run time: 115625 ms
Total hot run time: 49438 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4354	4318	4352	4318
q2	322	219	224	219
q3	4172	4117	4141	4117
q4	2754	2751	2735	2735
q5	7226	7205	7124	7124
q6	238	117	121	117
q7	3231	2865	2870	2865
q8	4420	4502	4496	4496
q9	14242	13713	14030	13713
q10	4227	4266	4227	4227
q11	747	671	691	671
q12	1030	863	874	863
q13	6982	3754	3709	3709
q14	457	445	426	426
q15	495	456	461	456
q16	644	597	590	590
q17	3979	3773	3847	3773
q18	8783	8848	8702	8702
q19	1733	1689	1664	1664
q20	2394	2124	2147	2124
q21	8488	8417	8547	8417
q22	1053	958	946	946
Total cold run time: 81971 ms
Total hot run time: 76272 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212376 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ef7bbe55219ddd75cfa4b7552fd53173fa347fff, data reload: false

query1	993	387	382	382
query2	6534	2246	2041	2041
query3	6918	202	202	202
query4	23074	21571	21625	21571
query5	19739	6515	6476	6476
query6	285	215	238	215
query7	4177	302	308	302
query8	246	276	239	239
query9	3080	2663	2611	2611
query10	426	315	310	310
query11	15755	15015	15612	15015
query12	129	77	73	73
query13	1029	457	435	435
query14	17477	13083	13462	13083
query15	365	220	224	220
query16	6499	294	262	262
query17	1733	961	943	943
query18	904	316	313	313
query19	218	151	150	150
query20	101	100	98	98
query21	190	99	99	99
query22	5168	5007	4992	4992
query23	34251	33671	33459	33459
query24	7895	6300	6310	6300
query25	538	438	447	438
query26	1279	166	160	160
query27	2488	297	297	297
query28	6130	2304	2271	2271
query29	2882	2839	2696	2696
query30	242	169	171	169
query31	975	734	741	734
query32	76	64	60	60
query33	457	271	261	261
query34	854	496	466	466
query35	1157	941	952	941
query36	1244	1295	1188	1188
query37	171	64	62	62
query38	3080	2985	2888	2888
query39	1369	1326	1328	1326
query40	304	95	97	95
query41	40	38	37	37
query42	93	88	81	81
query43	697	547	616	547
query44	1189	724	731	724
query45	246	231	229	229
query46	1225	965	956	956
query47	1900	1888	1700	1700
query48	500	401	415	401
query49	637	384	393	384
query50	864	604	626	604
query51	4751	4730	4670	4670
query52	87	77	79	77
query53	238	194	193	193
query54	2694	2456	2495	2456
query55	98	86	87	86
query56	221	206	206	206
query57	1283	1087	1108	1087
query58	225	212	204	204
query59	3363	3276	3127	3127
query60	218	218	191	191
query61	98	96	99	96
query62	773	467	446	446
query63	213	175	175	175
query64	3507	1584	1499	1499
query65	3643	3546	3567	3546
query66	783	434	444	434
query67	17399	15744	14943	14943
query68	11083	662	646	646
query69	504	268	278	268
query70	1881	1418	1399	1399
query71	414	303	310	303
query72	6732	4887	4851	4851
query73	784	332	316	316
query74	6273	5827	5813	5813
query75	5500	3673	3749	3673
query76	6633	1128	1228	1128
query77	1126	258	262	258
query78	12859	12034	11909	11909
query79	7918	645	658	645
query80	1302	407	387	387
query81	486	238	238	238
query82	1216	99	97	97
query83	162	138	132	132
query84	257	72	70	70
query85	895	320	326	320
query86	336	282	293	282
query87	3279	3078	3076	3076
query88	4098	2304	2293	2293
query89	449	293	272	272
query90	1992	214	215	214
query91	173	130	128	128
query92	60	50	50	50
query93	6675	611	583	583
query94	750	206	214	206
query95	2033	2020	2020	2020
query96	650	331	325	325
query97	6498	6400	6471	6400
query98	223	210	210	210
query99	3098	942	922	922
Total cold run time: 323756 ms
Total hot run time: 212376 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ef7bbe55219ddd75cfa4b7552fd53173fa347fff, data reload: false

query1	0.02	0.03	0.02
query2	0.07	0.02	0.02
query3	0.25	0.05	0.05
query4	1.78	0.08	0.06
query5	0.53	0.52	0.52
query6	1.23	0.62	0.62
query7	0.01	0.01	0.01
query8	0.03	0.02	0.03
query9	0.52	0.48	0.48
query10	0.53	0.52	0.53
query11	0.12	0.10	0.08
query12	0.11	0.09	0.10
query13	0.63	0.61	0.61
query14	0.77	0.77	0.78
query15	0.77	0.75	0.77
query16	0.38	0.40	0.38
query17	1.01	1.00	1.03
query18	0.24	0.26	0.24
query19	1.93	1.85	1.85
query20	0.02	0.01	0.01
query21	15.49	0.54	0.54
query22	2.02	2.20	1.74
query23	16.92	1.06	1.00
query24	5.33	1.08	1.63
query25	0.39	0.11	0.05
query26	0.62	0.16	0.14
query27	0.06	0.03	0.03
query28	7.02	0.79	0.72
query29	12.63	2.41	2.41
query30	0.60	0.55	0.56
query31	2.81	0.39	0.37
query32	3.39	0.50	0.50
query33	3.07	3.05	3.11
query34	15.22	4.84	4.81
query35	4.87	4.84	4.86
query36	1.05	1.02	1.02
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.15	0.14
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 102.82 s
Total hot run time: 31.2 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ef7bbe55219ddd75cfa4b7552fd53173fa347fff with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.5 seconds inserted 10000000 Rows, about 465K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants