Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](Nereids) bind schema table qualified column failed #46960 #47155

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #46960

### What problem does this PR solve?

Problem Summary:

since schema table's name is case insensitive, we should compare
column's qulifier with table name in SQL text, not with table's name in
meta data.
@github-actions github-actions bot requested a review from dataroaring as a code owner January 17, 2025 07:09
@Thearas
Copy link
Contributor

Thearas commented Jan 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 17, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 17, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40908 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5dc4948fa62597ed0071494ec568dfa5f9dcb28, data reload: false

------ Round 1 ----------------------------------
q1	17607	7377	7237	7237
q2	2069	178	173	173
q3	10582	1090	1212	1090
q4	10562	795	740	740
q5	7750	2823	2784	2784
q6	237	148	148	148
q7	983	616	604	604
q8	9362	1964	2044	1964
q9	6597	6403	6422	6403
q10	6987	2273	2279	2273
q11	470	264	267	264
q12	397	220	216	216
q13	17794	2983	3016	2983
q14	255	206	206	206
q15	560	532	535	532
q16	688	621	612	612
q17	981	601	555	555
q18	7140	6647	6724	6647
q19	1399	1085	1117	1085
q20	466	216	197	197
q21	4127	3298	3212	3212
q22	1107	983	1019	983
Total cold run time: 108120 ms
Total hot run time: 40908 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7260	7202	7223	7202
q2	331	236	234	234
q3	2946	2985	2992	2985
q4	2141	1863	1852	1852
q5	5706	5731	5706	5706
q6	224	143	150	143
q7	2272	1822	1841	1822
q8	3323	3571	3542	3542
q9	8885	8896	8792	8792
q10	3577	3539	3528	3528
q11	590	506	510	506
q12	787	616	582	582
q13	9432	3165	3182	3165
q14	325	291	282	282
q15	583	533	535	533
q16	738	682	694	682
q17	1839	1635	1600	1600
q18	8203	7626	7540	7540
q19	1668	1636	1572	1572
q20	2154	1859	1899	1859
q21	5584	5466	5390	5390
q22	1146	1063	1027	1027
Total cold run time: 69714 ms
Total hot run time: 60544 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197081 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5dc4948fa62597ed0071494ec568dfa5f9dcb28, data reload: false

query1	1272	944	943	943
query2	6234	2093	2085	2085
query3	10942	4437	4353	4353
query4	67113	29031	23557	23557
query5	4989	462	462	462
query6	426	178	177	177
query7	5602	305	318	305
query8	303	208	214	208
query9	9113	2648	2654	2648
query10	446	271	260	260
query11	17132	15188	15729	15188
query12	147	103	104	103
query13	1521	438	419	419
query14	10307	7232	6679	6679
query15	209	179	179	179
query16	7134	491	511	491
query17	1063	576	571	571
query18	1840	325	306	306
query19	212	159	165	159
query20	132	113	115	113
query21	202	108	103	103
query22	4751	4442	4215	4215
query23	34605	34192	34205	34192
query24	6103	2884	2954	2884
query25	547	434	421	421
query26	651	171	169	169
query27	1797	349	359	349
query28	4396	2497	2468	2468
query29	735	492	456	456
query30	244	169	166	166
query31	1006	824	854	824
query32	69	57	59	57
query33	491	298	289	289
query34	914	508	513	508
query35	852	742	722	722
query36	1070	960	957	957
query37	123	79	74	74
query38	4238	4023	3998	3998
query39	1514	1472	1496	1472
query40	213	106	114	106
query41	59	54	46	46
query42	117	100	96	96
query43	548	508	488	488
query44	1203	838	823	823
query45	187	175	174	174
query46	1147	724	718	718
query47	2041	1901	1937	1901
query48	478	380	377	377
query49	723	387	403	387
query50	866	439	438	438
query51	7321	7249	7218	7218
query52	104	90	89	89
query53	261	177	180	177
query54	552	463	456	456
query55	81	78	80	78
query56	246	245	242	242
query57	1244	1089	1119	1089
query58	210	205	213	205
query59	3253	3098	2982	2982
query60	287	266	251	251
query61	135	110	112	110
query62	770	665	674	665
query63	217	184	188	184
query64	1382	678	635	635
query65	3237	3209	3238	3209
query66	697	297	300	297
query67	15908	15833	15682	15682
query68	4113	574	567	567
query69	430	265	259	259
query70	1188	1124	1054	1054
query71	351	246	246	246
query72	6367	3995	4019	3995
query73	747	343	355	343
query74	10148	8922	8973	8922
query75	3358	2629	2612	2612
query76	1864	1058	1027	1027
query77	540	274	271	271
query78	10495	9638	9591	9591
query79	1394	594	601	594
query80	854	431	423	423
query81	503	249	238	238
query82	1288	124	118	118
query83	165	142	146	142
query84	284	80	81	80
query85	875	295	299	295
query86	333	301	300	300
query87	4488	4345	4264	4264
query88	3717	2404	2367	2367
query89	422	293	292	292
query90	1999	189	185	185
query91	179	169	147	147
query92	65	49	49	49
query93	1911	535	536	535
query94	777	303	297	297
query95	354	270	261	261
query96	613	279	284	279
query97	3325	3244	3173	3173
query98	215	208	205	205
query99	1610	1299	1297	1297
Total cold run time: 318904 ms
Total hot run time: 197081 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d5dc4948fa62597ed0071494ec568dfa5f9dcb28, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.02
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.52	0.49	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.57	0.50	0.50
query10	0.56	0.55	0.56
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.95	3.04	3.09
query15	0.90	0.83	0.83
query16	0.39	0.37	0.39
query17	1.07	0.98	1.06
query18	0.23	0.22	0.22
query19	1.87	1.87	1.98
query20	0.02	0.01	0.02
query21	15.39	0.61	0.61
query22	2.77	1.95	1.97
query23	16.92	1.05	0.84
query24	2.66	1.69	0.80
query25	0.25	0.16	0.09
query26	0.39	0.13	0.14
query27	0.05	0.05	0.04
query28	10.70	1.09	1.08
query29	12.59	3.26	3.28
query30	0.25	0.06	0.05
query31	2.87	0.38	0.38
query32	3.23	0.46	0.46
query33	2.99	2.98	3.07
query34	16.96	4.52	4.50
query35	4.59	4.59	4.56
query36	0.68	0.48	0.50
query37	0.10	0.07	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 106.91 s
Total hot run time: 33.13 s

@morrySnow
Copy link
Contributor

run cloud_p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants