Support full StreamLoad feature in multiload #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangzhg
force-pushed
the
support_multiload
branch
3 times, most recently
from
37ac90b to
67e4c49
Compare
yangzhg
force-pushed
the
support_multiload
branch
2 times, most recently
from
f5b3061 to
f7458ab
Compare
morningman
added
the
kind/feature
yangzhg
force-pushed
the
support_multiload
branch
from
f7458ab to
a562125
Compare
yangzhg
force-pushed
the
support_multiload
branch
from
8b476e8 to
df6c866
Compare
yangzhg
force-pushed
the
support_multiload
branch
2 times, most recently
from
61499bb to
f367796
Compare
yangzhg
force-pushed
the
support_multiload
branch
from
34b1c9d to
17c8e40
Compare
yangzhg
force-pushed
the
support_multiload
branch
from
4102daf to
e5805c5
Compare
morningman
approved these changes
Dec 9, 2020
| // Prepare request parameters. | ||
| std::map<std::string, std::string> params( | ||
| http_req->query_params().begin(), http_req->query_params().end()); | ||
| RETURN_IF_ERROR(_merge_header(http_req, ¶ms)); |
There was a problem hiding this comment.
Add a comment to say that the param in header will overwrite the query params
| @@ -199,5 +199,5 @@ | |||
| //jira: 4863 for load job support udf | |||
| public static final int VERSION_93 = 93; | |||
| // note: when increment meta version, should assign the latest version to VERSION_CURRENT | |||
| public static final int VERSION_CURRENT = VERSION_93; | |||
| public static final int VERSION_CURRENT = VERSION_92; | |||
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 10, 2020
Change-Id: I307bfaaf608b743c8dd9991dccd675163a568d7f
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement #4715
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...