Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix bug and optimize implementation logic of tablets web page #4775

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

weizuo93
Copy link
Contributor

Proposed changes

(1) The implementation logic of tablets web page is that:
  Firstly, get all the tablets of the BE;
  Secondly, return specific number tablets in front to web page according to the value of request parameter limit.
This patch optimize the implementation logic of tablets web page that getting specific number tablets in BE according to the value of request parameter limit and then return them to web page.

(2) It will return default 1000 tablets through http interface http://be_host:webserver_port/tablets_page. If the number of tablet in the BE is less than 1000, there will be coredump in the following code:

be/src/http/action/tablets_info_action.cpp
2020-10-21 16-27-08 的屏幕截图
2020-10-21 16-27-27 的屏幕截图
This patch fixed the bug.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added the approved Indicates a PR has been approved by one committer. label Oct 27, 2020
@morningman morningman merged commit 6790254 into apache:master Oct 28, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@weizuo93 weizuo93 deleted the tablets_webpage_bugfix branch March 9, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants