[Bug][Compaction] Fix bug that output rowset is not deleted after compaction failure. #4964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
xy720
reviewed
Nov 26, 2020
be/src/olap/reader.h
Outdated
| @@ -128,7 +128,7 @@ class Reader { | |||
| } | |||
|
|
|||
| uint64_t filtered_rows() const { | |||
| return _stats.rows_del_filtered; | |||
There was a problem hiding this comment.
Hi, is it compatible with segment v1?
In alpha_rowset_reader.h, filtered_rows() only calculates rows_del_filtered.
There was a problem hiding this comment.
Yes, it is compatible. Because rows_conditions_filtered is only used for SegmentV2, so it should always to 0 in Segment V1.
chaoyli
requested changes
Nov 27, 2020
chaoyli
previously approved these changes
Nov 30, 2020
morningman
force-pushed
the
compaction_gc_bug
branch
from
ec5186b to
8ea8fa5
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This CL fix 2 bugs:
When the compaction fails, we must explicitly delete the output rowset,
otherwise the GC logic cannot process these rows.
Base compaction failed if compaction process include some delete version in SegmentV2,
Because the number of filtered rows is wrong.
Types of changes
Checklist