Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance Optimization] Remove push down conjuncts in olap scan node #4999

Merged
merged 2 commits into from
Dec 6, 2020

Conversation

HappenLee
Copy link
Contributor

Proposed changes

Push conjunct to Storage Engine as more as possible

olap scan node do not need filter data use push down conjuncts again.

fix #4986

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

…de, push conjunct to Storage Engine as more as possible

olap scan node do not need filter data use push down conjuncts again.

issue:apache#4986
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/sql/execution Issues or PRs related to the execution engine area/storage Issues or PRs related to storage engine kind/improvement labels Dec 5, 2020
@morningman morningman merged commit 6021d6f into apache:master Dec 6, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/sql/execution Issues or PRs related to the execution engine area/storage Issues or PRs related to storage engine kind/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Remove idle conjuncts in olap scan node which had alreadly push to Storage Engine
2 participants