Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repair] Add an option whether to allow the partition column to be NULL #5013

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Dec 2, 2020

Proposed changes

Add an option allow_partition_column_nullable, which means whether to allow the partition column to be NULL.
When the option is enabled, the partition column must be NOT NULL when create table, otherwise an error will be reported.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

@morningman morningman added the api-review Categorizes an issue or PR as actively needing an API review. label Dec 4, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Dec 4, 2020
@kangkaisen kangkaisen merged commit c5f7803 into apache:master Dec 5, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by one committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add an option whether to allow the partition column to be NULL
3 participants