Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Fix] Fix partition cache match bug #5060

Merged
merged 40 commits into from
Dec 19, 2020

Conversation

xinghuayu007
Copy link
Contributor

Proposed changes

When partition cache is not cached continuely, range query may fail. For example, partition key 20201011 and 20201013 is cached, but rang query is between 20201011 and 20201013, the query will not hit the cache.
issue:#5059

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

wangxixu added 30 commits August 13, 2020 22:09
@wuyunfeng wuyunfeng added the area/sql/cache Issues or PRs related to sql cache label Dec 10, 2020
@wuyunfeng wuyunfeng linked an issue Dec 10, 2020 that may be closed by this pull request
@wuyunfeng wuyunfeng changed the title [Bug] Fix partition cache match bug [Bug-Fix] Fix partition cache match bug Dec 10, 2020
@xinghuayu007 xinghuayu007 reopened this Dec 10, 2020
@xinghuayu007 xinghuayu007 reopened this Dec 11, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Dec 18, 2020
@morningman morningman merged commit 9ddf434 into apache:master Dec 19, 2020
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
When partition cache is not cached continuely, range query may fail.
For example, partition key 20201011 and 20201013 is cached,
but rang query is between 20201011 and 20201013, the query will not hit the cache.
issue:apache#5059
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/sql/cache Issues or PRs related to sql cache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] partition cache match failed
3 participants