Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Memory Leak in Json Load #5073

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Dec 12, 2020

Proposed changes

fix json load memory leak #5069

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (fix json load memory leak which fixes an issue-5069)
  • Code refactor (use unique_ptr instead of native ptr)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix [Bug] BE Memory Leak In Json Load #5069 ), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • Any dependent changes have been merged

@stdpain stdpain changed the title [Bug] Fix Memory Leak in Json Load #5069 [Bug] Fix Memory Leak in Json Load Dec 12, 2020
be/src/exec/local_file_reader.cpp Outdated Show resolved Hide resolved
@stdpain stdpain force-pushed the fix_json_load_leak branch 3 times, most recently from 7c82af8 to 7b0d477 Compare December 12, 2020 09:39
HappenLee
HappenLee previously approved these changes Dec 12, 2020
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdpain stdpain requested a review from imay December 13, 2020 07:03
morningman
morningman previously approved these changes Dec 14, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added area/load Issues or PRs related to all kinds of load kind/fix Categorizes issue or PR as related to a bug. labels Dec 14, 2020
imay
imay previously approved these changes Dec 14, 2020
@morningman morningman added the approved Indicates a PR has been approved by one committer. label Dec 14, 2020
@stdpain stdpain dismissed stale reviews from imay, morningman, and HappenLee via 0eaa906 December 15, 2020 02:14
@stdpain stdpain requested review from imay and morningman December 15, 2020 05:03
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 6afa14c into apache:master Dec 15, 2020
@stdpain stdpain deleted the fix_json_load_leak branch December 18, 2020 08:30
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BE Memory Leak In Json Load
4 participants