-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix Memory Leak in Json Load #5073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
changed the title
[Bug] Fix Memory Leak in Json Load #5069
[Bug] Fix Memory Leak in Json Load
Dec 12, 2020
imay
requested changes
Dec 12, 2020
stdpain
force-pushed
the
fix_json_load_leak
branch
3 times, most recently
from
December 12, 2020 09:39
7c82af8
to
7b0d477
Compare
stdpain
force-pushed
the
fix_json_load_leak
branch
from
December 12, 2020 09:41
7b0d477
to
6e81403
Compare
HappenLee
previously approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
previously approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
added
area/load
Issues or PRs related to all kinds of load
kind/fix
Categorizes issue or PR as related to a bug.
labels
Dec 14, 2020
imay
previously approved these changes
Dec 14, 2020
stdpain
dismissed stale reviews from imay, morningman, and HappenLee
via
December 15, 2020 02:14
0eaa906
morningman
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jan 5, 2021
fix json load memory leak apache#5069
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix json load memory leak #5069
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.