Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add system memory metrics for fe #5149

Merged
merged 2 commits into from
Jan 17, 2021
Merged

[Enhancement] Add system memory metrics for fe #5149

merged 2 commits into from
Jan 17, 2021

Conversation

Dam1029
Copy link
Contributor

@Dam1029 Dam1029 commented Dec 25, 2020

Proposed changes

Currently, fe's SystemMetrics only support tcp. I add system memory metrics for fe. Then we can get system memory metrics , which is used to troubleshoot memory problems.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman self-assigned this Jan 16, 2021
@morningman morningman added the area/metrics Issues or PRs related to the metrics label Jan 16, 2021
morningman
morningman previously approved these changes Jan 16, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

Hi @Dam1029 please resolve the conflict

@Dam1029
Copy link
Contributor Author

Dam1029 commented Jan 16, 2021

Hi @Dam1029 please resolve the conflict

ok. I have resolved the conflict.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 73a6790 into apache:master Jan 17, 2021
@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 17, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
Currently, fe's SystemMetrics only support tcp. I add system memory metrics for fe.
Then we can get system memory metrics , which is used to troubleshoot memory problems.
@zh0122 zh0122 mentioned this pull request Feb 4, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/metrics Issues or PRs related to the metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants