Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix bug that the min/max function has an error in handling string null values #5189

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

morningman
Copy link
Contributor

Proposed changes

null should be ignored in min/max function.
And if there is no data, null should be return.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

…ng null values.

null should be ignored in min/max function.
And if there is no data, null should be return.
@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Jan 4, 2021
@morningman morningman self-assigned this Jan 4, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Jan 4, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg merged commit 03e3605 into apache:master Jan 5, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
…ng null values. (apache#5189)

null should be ignored in min/max function.
And if there is no data, null should be return.

Co-authored-by: morningman <chenmingyu@baidu.com>
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong query result of min/max for string type col
4 participants