[optimization] avoid extra memory copy while build hash table #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
force-pushed
the
optimize_hash_table_build
branch
from
7b86ef7 to
4c102ea
Compare
wangbo
reviewed
Jan 26, 2021
wangbo
reviewed
Jan 26, 2021
wangbo
reviewed
Jan 26, 2021
wangbo
reviewed
Jan 27, 2021
wangbo
reviewed
Jan 27, 2021
wangbo
reviewed
Jan 27, 2021
| // TODO: integrate with mem pools | ||
| uint8_t* _nodes; | ||
| // Buffer to store node data. | ||
| uint8_t* _current_nodes; | ||
| // number of nodes stored (i.e. size of hash table) | ||
| int64_t _num_nodes; |
There was a problem hiding this comment.
Suggested change
| int64_t _num_nodes; | |
| int64_t _total_used; |
Easier to understand
Co-authored-by: wangbo <506340561@qq.com>
wangbo
added
the
area/sql/execution
Closed
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 21, 2021
…#5301) avoid extra memory copy while build hash table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
avoid extra memory copy while build hash table
reference to #5300
Types of changes
Checklist
Further comments
This modification may have a performance improvement of more than 25% during the hash table construction phase.