Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support create index on unique value column #5305

Merged

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Jan 27, 2021

Proposed changes

Support create index on unique value column, accelerate the scan of update, part of #5270

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on ([Proposal]Doris UNIQUE table supports UPDATE syntax #5270) and described the feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If these changes need document changes, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does adding an index to the value column only require development restrictions?
No other changes needed?

@yangzhg
Copy link
Member Author

yangzhg commented Jan 29, 2021

Does adding an index to the value column only require development restrictions?
No other changes needed?

All columns have the ability to create indexes, but it is prohibited when fe planning the exec plan

@yangzhg yangzhg requested a review from EmmyMiao87 February 2, 2021 03:55
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Feb 2, 2021
@yangzhg yangzhg merged commit 47e33c7 into apache:master Feb 3, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@yangzhg yangzhg deleted the support_create_index_on_unique_value_column branch April 12, 2021 02:52
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Apr 21, 2021
* support create index on unique table value columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants