Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Function] Support date function: yearweek(), week(), makedate(). #6000

Merged
merged 5 commits into from
Jun 10, 2021

Conversation

luozenglin
Copy link
Contributor

…999)

Proposed changes

Support date functions that can be found in mysql : yearweek(), week(), makedate().

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix Support for date functions: yearweek(), week(), makedate() #5999) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@luozenglin luozenglin changed the title [Function] Support date function: yearweek(), week(), makedate(). (#5… [Function] Support date function: yearweek(), week(), makedate(). Jun 8, 2021
@morningman morningman added the area/sql/function Issues or PRs related to the SQL functions label Jun 9, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document needs to be added to the
docs/.vuepress/sidebar/zh-CN.js
and
docs/.vuepress/sidebar/en.js

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit d33a6d1 into apache:master Jun 10, 2021
@morningman morningman mentioned this pull request Oct 10, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Nov 10, 2021
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
…ache#6000)

Conflicts:
	be/src/exprs/timestamp_functions.cpp
	be/src/exprs/timestamp_functions.h
	be/src/runtime/datetime_value.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql/function Issues or PRs related to the SQL functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for date functions: yearweek(), week(), makedate()
3 participants