[RoutineLoad] Support alter broker list and topic for kafka routine load #6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Jul 28, 2021
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| import com.clearspring.analytics.util.Lists; |
| sb.append(")\n"); | ||
| // 6. data_source | ||
| sb.append("FROM ").append(dataSourceType).append("\n"); | ||
| // 7. data_source_properties | ||
| sb.append("(\n"); | ||
| getDataSourceProperties().forEach((k, v) -> appendProperties(sb, k, v, false)); | ||
| getCustomProperties().forEach((k, v) -> appendProperties(sb, k, v, false)); | ||
| // remove the last , | ||
| if (progress instanceof KafkaProgress) { | ||
| List<Pair<Integer, String>> pairs = ((KafkaProgress) progress).getPartitionOffsetPairs(false); |
There was a problem hiding this comment.
Shown here is the offset specified when creating the task?
Or the offset that has already been consumed?
There was a problem hiding this comment.
offset to be consumed. I will add comment and document
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
songchuangyuan
pushed a commit
to songchuangyuan/incubator-doris
that referenced
this pull request
Aug 20, 2021
…oad (apache#6335) ``` alter routine load for cmy2 from kafka("kafka_broker_list" = "ip2:9094", "kafka_topic" = "my_topic"); ``` This is useful when the kafka broker list or topic has been changed. Also modify `show create routine load`, support showing "kafka_partitions" and "kafka_offsets".
Closed
songchuangyuan
pushed a commit
to songchuangyuan/incubator-doris
that referenced
this pull request
Oct 18, 2021
…oad (apache#6335) ``` alter routine load for cmy2 from kafka("kafka_broker_list" = "ip2:9094", "kafka_topic" = "my_topic"); ``` This is useful when the kafka broker list or topic has been changed. Also modify `show create routine load`, support showing "kafka_partitions" and "kafka_offsets".
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Nov 10, 2021
…oad (apache#6335) ``` alter routine load for cmy2 from kafka("kafka_broker_list" = "ip2:9094", "kafka_topic" = "my_topic"); ``` This is useful when the kafka broker list or topic has been changed. Also modify `show create routine load`, support showing "kafka_partitions" and "kafka_offsets".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is useful when the kafka broker list or topic has been changed.
Also modify
show create routine load, support showing "kafka_partitions" and "kafka_offsets".Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...