-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alter] Support alter table and column's comment #6387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/feature
Categorizes issue or PR as related to a new feature.
area/alter
labels
Aug 5, 2021
xy720
previously approved these changes
Aug 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
1. alter table tbl1 modify comment "new comment"; 2. alter table tbl1 modify column k1 comment "k1", modify column v1 comment "v1";
Please add a issue link |
EmmyMiao87
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Aug 10, 2021
PR approved by at least one committer and no changes requested. |
songchuangyuan
pushed a commit
to songchuangyuan/incubator-doris
that referenced
this pull request
Aug 20, 2021
1. alter table tbl1 modify comment "new comment"; 2. alter table tbl1 modify column k1 comment "k1", modify column v1 comment "v1";
Closed
songchuangyuan
pushed a commit
to songchuangyuan/incubator-doris
that referenced
this pull request
Oct 18, 2021
1. alter table tbl1 modify comment "new comment"; 2. alter table tbl1 modify column k1 comment "k1", modify column v1 comment "v1";
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Nov 10, 2021
1. alter table tbl1 modify comment "new comment"; 2. alter table tbl1 modify column k1 comment "k1", modify column v1 comment "v1"; Change-Id: I85c6e0749fca7966973730449ca54ba16cc14cf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/alter
kind/feature
Categorizes issue or PR as related to a new feature.
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...