Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][manager] Modify the code according to the prototype #7346

Merged
merged 76 commits into from
Dec 11, 2021

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Dec 8, 2021

Proposed changes

  1. Increase Broker installation, configuration and distribution, start and stop interfaces
  2. Refactor the low-level implementation of installation services, distribution configuration, startup, etc.
  3. Increase the node hardware information interface, etc.
  4. The agent adds the function of viewing task logs and interfaces, etc.
  5. Increase task retry, skip interface, etc.
  6. Modify some interfaces, etc. according to the prototype

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

wudi and others added 30 commits August 26, 2021 17:59
2. When the agent service restarts, get the installed service from the server and save it to the agent
3. The configuration of be and fe can be sent to the agent side during installation
4. Support fe installation, and when issuing the fe configuration file fe.conf, choose whether to automatically create a metadata directory according to the meta_dir value in the configuration file
5. Support be installation, and when the be configuration file be.conf is issued, select whether to automatically create a data storage directory according to the storage_root_path value in the configuration file
6. Support the registration of the existing doris cluster to the agent
7. Support one agent node can install multiple services, such as fe, be
8. Some other optimizations, such as interface parameter verification, code formatting, etc.
# Conflicts:
#	manager/build.sh
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

PR approved by anyone and no changes requested.

@morningman morningman merged commit e0c62e9 into apache:doris-manager Dec 11, 2021
@morningman
Copy link
Contributor

#7591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants