-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compile] Support build with clang #7451
Conversation
Maybe provide clang in thrid-party or docker image? |
@@ -18,13 +18,6 @@ | |||
cmake_minimum_required(VERSION 3.19.2) | |||
|
|||
# set CMAKE_C_COMPILER, this must set before project command | |||
if (DEFINED ENV{DORIS_GCC_HOME}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be an optional choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx
We define GCC HOME because bitshuffle's build process depend on GCC_HOME/ld. I will rewrite bitshuffle build method use cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to build with clang, then we export CC=XXXX/clang and CXX=XXXXXXX/clang++
If we want to build with gcc, then we export CC=xxxx/gcc and CXX=xxxxx/g++
Currently, could only build be with clang, And I don't want it to be an optional args because I think we should use clang as default build tool chain in the future. |
It seems that |
Support build Doris BE with clang
Currently, thirdparty could only be build with GCC