[Improvement] support build thirdparty and BE using clang #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 2, 2022 18:38
|
I think we need to document to explain when and how to use clang or gcc. |
amosbird
reviewed
Jan 9, 2022
| } | ||
| current_size = new_size; | ||
| } | ||
|
|
||
| template class DataBuffer<bool>; |
There was a problem hiding this comment.
"explicit template instantiation" is definition and should be in source file (translation unit), or else in theory it's ODR violation. In practice it doesn't make sense to have them in header files (outline defined) which slows down compilation and leads to problems you're trying to work around.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, I think we should only support Clang.