[fix](catalog) fix bug that replica missing version cause query -214 error #9266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
morningman
commented
Apr 27, 2022
| // the replica is normal, then remove it from error replica ids | ||
| errorReplicaIds.remove(replica.getId()); | ||
| && replica.getLastFailedVersion() < 0 | ||
| && replica.checkVersionCatchUp(partition.getVisibleVersion(), true)) { |
There was a problem hiding this comment.
For reviewer: Remove this part because we will update the replica version in updateCatalogAfterVisible(), so no need to update here.
yiguolei
reviewed
Apr 28, 2022
| @@ -831,8 +831,12 @@ private static void handleRecoverTablet(ListMultimap<Long, Long> tabletRecoveryM | |||
| // The absolute value is meaningless, as long as it is greater than 0. | |||
There was a problem hiding this comment.
delete or update the comment
yiguolei
reviewed
Apr 28, 2022
| } | ||
| } else if (replica.getVersion() >= partitionCommitInfo.getVersion()) { | ||
| // the replica's version is larger than or equal to current transaction partition's version | ||
| // the replica is normal, then remove it from error replica ids |
There was a problem hiding this comment.
This logic is not covered by updateCatalogAfterVisible.
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
stalary
pushed a commit
to stalary/doris
that referenced
this pull request
May 5, 2022
…error (apache#9266) 1. Fix bug described in apache#9267 When report missing version replica, set last failed version to (replica version + 1) 2. Skip non-exist partition when handling transactions.
morningman
added
dev/merged-1.0.1-deprecated
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
May 9, 2022
…error (apache#9266) 1. Fix bug described in apache#9267 When report missing version replica, set last failed version to (replica version + 1) 2. Skip non-exist partition when handling transactions.
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
…error (apache#9266) 1. Fix bug described in apache#9267 When report missing version replica, set last failed version to (replica version + 1) 2. Skip non-exist partition when handling transactions.
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
…error (apache#9266) 1. Fix bug described in apache#9267 When report missing version replica, set last failed version to (replica version + 1) 2. Skip non-exist partition when handling transactions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9267
Problem Summary:
This CL mainly change:
When report missing version replica, set last failed version to (replica version + 1)
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...