Optimize rowset usage #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kangpinghuang
commented
Apr 16, 2019
•
kangpinghuang
commented
- optimize incremental rowsetshared ptr ref to aquire the rowset object
- add unused_rowset_thread to delete unused rowset
- add need_delete_flag to mark deleted rowset
- optimize AlphaRowsetReader's constructor
yiguolei
reviewed
Apr 16, 2019
| void set_need_delete_file(bool need_delete_file) { | ||
| _need_delete_file = need_delete_file; | ||
| } | ||
|
|
There was a problem hiding this comment.
add a check here. if it is set need deleted it could not be reverted.
chaoyli
requested changes
Apr 16, 2019
be/src/olap/storage_engine.cpp
Outdated
| auto it = _unused_rowsets.begin(); | ||
| for (; it != _unused_rowsets.end();) { | ||
| if (it->second->in_use()) { | ||
| LOG(INFO) << "start to delete unused rowset."; |
There was a problem hiding this comment.
Log is non-sense when has no unused rowset.
| } else if (it->second->need_delete_file()){ | ||
| LOG(INFO) << "start to remove rowset:" << it->second->rowset_id() | ||
| << ", version:" << it->second->version().first << "-" << it->second->version().second; | ||
| OLAPStatus status = it->second->remove(); |
There was a problem hiding this comment.
if failed, you can not remove it from unused rowset.
| virtual bool delete_flag() = 0; | ||
|
|
||
| virtual bool check_path(const std::string& path) = 0; | ||
|
|
||
| bool need_delete_file() { | ||
| return _need_delete_file; |
There was a problem hiding this comment.
if _need_delete_file = false and rowset shared_ptr use_count() == 1 will happen meanwhile?
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Nov 18, 2022
* [Feature-WIP](inverted) add inverted index compaction implementation (apache#851) * [Feature-WIP](inverted) add inverted index compaction implementation * [Feature-WIP](inverted) set condition for rowid vec trans * [Fix](inverted) remove useless function * [Fix](inverted) seperate compound directory fs and cfs, for cloud mode and other situations Co-authored-by: airborne12 <airborne08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.