Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Fix DateFormat in DateGen.java #2959

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DRAFT] Fix DateFormat in DateGen.java #2959

wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

See #2958

This change is experimental.

pjfanning
pjfanning commented Oct 26, 2024
View reviewed changes
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/DateGen.java
long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
String str = fmt.format(new Date(randTime));
colWriter.setString(str);
final long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnturton @cgivre this doesn't look right - baseTime is a big number but we add it twice so the result will be a very big number, a long way in the future.

@pjfanning pjfanning marked this pull request as draft October 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjfanning