fix off by one error in nested column range index #13405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imply-cheddar
approved these changes
Nov 22, 2022
gianm
approved these changes
Nov 22, 2022
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Nov 23, 2022
rohangarg
pushed a commit
that referenced
this pull request
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with nested column range index computation which was resulting in an off by 1 on the end index. #13297 almost fixed all of the issues, but as a showcase of how test line and branch coverage just tells you what you want to hear, the test cases were missing a scenario where the end of the range was missing locally, and there were additional global values between the global id of the 'insertion point' of the missing value and the actual global end value. I've added data to the test which covers this case to the string dictionary (which caused a few additional tests to fail prior to the fixes in this PR), as well as additional test cases for range indexes to i think cover all of the scenarios.... i hope 😅
This PR has: