Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: Compaction history dialog #13861

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

vogievetsky
Copy link
Contributor

This PR builds a UI on top of #13699

Allows you to see the history:

image

And do diffs:

image

This PR also cleans up some other names:

  • ShowHistory => SupervisorHistoryPanel
  • CompactionDialog => CompactionConfigDialog

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, pretty neat!
Tried the following:

  • Changing some fields
  • Deleting and recreating the compaction config
    History and diff work as expected in all the cases.

@vogievetsky vogievetsky merged commit 38b6373 into apache:master Mar 6, 2023
@vogievetsky vogievetsky deleted the compaction-history branch March 6, 2023 19:52
317brian pushed a commit to 317brian/druid that referenced this pull request Mar 10, 2023
* initial renames

* add comaction history diff

* final fixes

* update snapshots

* use maps

* update test
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants