fix KafkaInputFormat when used with Sampler API #13900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13879.
Description
Fixes issues when using
KafkaInputFormat
with the sampler API. My initial assessment in #13879 was only partially correct. The implementation of thesample
method inKafkaInputReader
also wasn't really correct since by just using the normal read path it did not correctly captureParseException
and so would fail immediately. I've adjusted thesample
method to delegate to the underlying readerssample
, which will correctly handle these, and changed the blending to occur on theInputRowListPlusRawValues
of the underlying sample call instead.Release note
The
KafkaInputFormat
now supports using the sampler API/druid/indexer/v1/sampler
.This PR has: