Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure console tile #15820

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

georgew5656
Copy link
Contributor

Switching druid web-console to suggest using the azureStorage input type instead of the azure input type due to changes from 3e51224

Description

The azureStorage input type is more full featured for azure ingestion than the azure input type so the console should suggest using it instead.

imo using a sas token for authentication is the best solution (outside of using managed auth) because sas tokens can be short lived.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

  • Updated azure ingestion tiles to use the azureStorage input source
  • allow specifying a static sas token through the console.

Release note

  • Updates to the web-console to use new input spec for azure
Key changed/added classes in this PR
  • external-config.ts
  • ingestion-spec.tsx
  • load-data-view.tsx

This PR has:

  • [ X been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@vogievetsky vogievetsky merged commit edb1ac1 into apache:master Feb 5, 2024
11 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants