Web console: make double detection better #15998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Feb 29, 2024
cryptoe
pushed a commit
to cryptoe/druid
that referenced
this pull request
Mar 6, 2024
vogievetsky
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a type detection issue where the
vcolumn in a CSV likeWould be detected as BIGINT instead of DOUBLE because we never considered the string representation of the number.
Also fixing a bug that I stumbled on when testing the above issue. The InputFormat detection step let's a user click next when a resample is needed putting them in a bad state because the signature is only detected on sample. I did that by mistake while testing.