Support CPU resource configurable for Kubernates job under MoK Mode #16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will take a look at this today, looks pretty reasonable |
georgew5656
reviewed
Mar 1, 2024
| @@ -572,14 +576,72 @@ void testEphemeralStorageIsRespected() throws IOException | |||
| Assertions.assertEquals(expected, actual); | |||
| } | |||
|
|
|||
| @Test | |||
| void testEphemeralResourceIsEspected() throws IOException | |||
There was a problem hiding this comment.
i think this test name is wrong, seems like it should be more like testCPUResourceIsRespected
| |`druid.indexer.runner.annotations`| `JsonObject` | Additional annotations you want to add to peon pod |`{}`|No| | ||
| |`druid.indexer.runner.peonMonitors`| `JsonArray` | Overrides `druid.monitoring.monitors`. Use this property if you don't want to inherit monitors from the Overlord. |`[]`|No| | ||
| |`druid.indexer.runner.graceTerminationPeriodSeconds`| `Long` | Number of seconds you want to wait after a sigterm for container lifecycle hooks to complete. Keep at a smaller value if you want tasks to hold locks for shorter periods. |`PT30S` (K8s default)|No| | ||
| |`druid.indexer.runner.capacity`| `Integer` | Number of concurrent jobs that can be sent to Kubernetes. |`2147483647`|No| |
There was a problem hiding this comment.
can you use the intellij props from here so the whole table doesn't get replaced like this? https://github.com/apache/druid/blob/master/dev/druid_intellij_formatting.xml#L77-L80
intellij config instructions: https://github.com/apache/druid/blob/master/dev/intellij-setup.md
georgew5656
approved these changes
Mar 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16007 .
Description
Make CPU core configurable for Kubernetes job(Peon) under MoK Mode
Currently the CPU core for Peon is fixed to 1, this PR is to support adjusting it by adding a Overlord property:
druid.indexer.runner.cpuCoreInMicro=2000Verification
Release note
Key changed/added classes in this PR
KubernetesTaskRunnerConfigPeonCommandContextK8sTaskAdapterDruidK8sConstantsThis PR has: