Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update common-compress to address CVE-2024-25710 CVE-2024-26308 #16009

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

janjwerner-confluent
Copy link
Contributor

@janjwerner-confluent janjwerner-confluent commented Feb 29, 2024

Description

  • Update common-compress to 1.26.0 to address CVEs CVE-2024-25710 CVE-2024-26308
  • Add commons-codec as a runtime dependency required by common-compress 1.26.0

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@janjwerner-confluent janjwerner-confluent changed the title update common-compress update common-compress to address CVE-2024-25710 CVE-2024-26308 Feb 29, 2024
@janjwerner-confluent
Copy link
Contributor Author

This resolves:
#15932
adding commons-codec as the required dependency of processing

<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<scope>runtime</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we need to add this dependency to the processing pom?
It also seems odd we would only be declaring it a runtime dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's added to processing as this is where commons-compress is used.
The dependency is listed as optional for commons-compress (https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.26.0)
and is not needed compile time. The dependency is needed runtime (as illustrated by failing tests in #15932). If we add it in the compile scope we will need to add the suppression of dependency analyze tool.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can we add a comment to explain the reason for making it runtime?

Let's also update the PR description to mention that 1.26 added this optional dependency and that it is required in our case to make tests pass.

processing/pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
@xvrl xvrl merged commit baaa4a6 into apache:master Feb 29, 2024
84 checks passed
@janjwerner-confluent janjwerner-confluent deleted the update-common-compress branch February 29, 2024 23:12
pagrawal10 pushed a commit to confluentinc/druid that referenced this pull request Apr 2, 2024
…he#16009)

* Update common-compress to 1.26.0 to address CVEs CVE-2024-25710 CVE-2024-26308
* Add commons-codec as a runtime dependency required by common-compress 1.26.0

---------

Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
pagrawal10 pushed a commit to confluentinc/druid that referenced this pull request Apr 2, 2024
…he#16009)

* Update common-compress to 1.26.0 to address CVEs CVE-2024-25710 CVE-2024-26308
* Add commons-codec as a runtime dependency required by common-compress 1.26.0

---------

Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants