fix ColumnType to RelDataType conversion for nested arrays #16138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RowSignatures.toRelDataType
did not correctly handle conversion of nested array types such asARRAY<ARRAY<LONG>>
etc, since theARRAY
handling case only checked for the primitive column types. I have modified this code to split out theColumnType
toRelDataType
conversion into a new method,RowSignatures. columnTypeToRelDataType
, and handle arrays by recursively calling this method to convert the element type to aRelDataType
so that it can handle any type of Druid array.I kind of think this method maybe should be moved into
Calcites
since a bunch of the other conversion methods that don't involveRowSignature
live there, but I haven't moved it yet...Only the second added test would fail, despite just being a count(*) wrapper around the first one. Apparently this query used to run fine, but I believe the changes in #16033 which resulted in
RowSignatures.toRelDataType
started exercising this path a bit more frequently, which is how the problem was noticed.This PR has: