Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Double & null values in sql type array through dynamic params #16274

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

sreemanamala
Copy link
Contributor

Description

This PR aims to take in null & double values while passed through dynamic parameters inside sql type ARRAY

Though we currently will not be able to see the option in UI, this can be achieved through API request.
sample request body's parameters would look like
"parameters":[{"type":"ARRAY","value":[d1, d2, null]}]

Release note

Double & Null values can be passed in Array through dynamic parameter


Key changed/added classes in this PR
  • SqlParameterizerShuttle.java
  • CalciteArraysQueryTest.java

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kgyrtkirk kgyrtkirk merged commit 5247059 into apache:master Apr 15, 2024
85 checks passed
@sreemanamala sreemanamala deleted the dynamic-params branch April 15, 2024 10:28
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants