fix auto type column indexer realtime logical type to report long if all nulls since it is most restrictive type #16828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all nulls to match serialized segment if all null values
clintropolis
changed the title
findingrish
reviewed
Aug 8, 2024
| // we didn't see anything, so we can be anything, so why not a string? | ||
| return ColumnType.STRING; | ||
| // we didn't see anything, so we can be anything, so be long as it is the most restrictive type | ||
| return ColumnType.LONG; |
There was a problem hiding this comment.
If this column is seen previously, should it just return that type?
There was a problem hiding this comment.
the issue here is that there have been no values other than nulls so far, so we can't know a type yet
There was a problem hiding this comment.
In the scenario when the ingestion spec doesn't have any custom dimensions, new incremental index is initialized with columns from previous index https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/segment/realtime/sink/Sink.java#L379, in that case it would probably be better to return the previous seen type?
…constant-null-realtime-type
findingrish
approved these changes
Sep 3, 2024
cryptoe
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report logical type as
LONGinstead ofSTRINGsinceLONGis the more restrictive type.