Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window Functions : Remove enable windowing flag #17087

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Window Functions : Remove enable windowing flag #17087

merged 7 commits into from
Sep 23, 2024

Conversation

sreemanamala
Copy link
Contributor

@sreemanamala sreemanamala commented Sep 17, 2024 •
edited
Loading

Description

This commits removes the enableWindowing flag and allows the window function queries by default

Key changed/added classes in this PR
  • DruidSqlValidator

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 17, 2024
@LakshSingla LakshSingla added this to the 31.0.0 milestone Sep 23, 2024
@kgyrtkirk kgyrtkirk merged commit 67d361c into apache:master Sep 23, 2024
90 checks passed
@sreemanamala sreemanamala deleted the enable-windowing branch September 23, 2024 06:25
sreemanamala added a commit to sreemanamala/druid that referenced this pull request Sep 23, 2024
@sreemanamala
Window Functions : Remove enable windowing flag (apache#17087)
aaa6e0b 
(cherry picked from commit 67d361c)
@sreemanamala sreemanamala mentioned this pull request Sep 23, 2024
Merged
kgyrtkirk pushed a commit that referenced this pull request Sep 24, 2024
@sreemanamala
Window Functions : Remove enable windowing flag (#17087) (#17128)
b7cc0bb 
(cherry picked from commit 67d361c)
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - Documentation Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreemanamala @kgyrtkirk @LakshSingla