MSQ: Add exception messages to WorkerFailedFault and WorkerRpcFailedFault. #17317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault. It's useful for the fault message to have some description of the underlying error: why did the worker fail, or why did the RPC call fail? This patch updates the fault messages to include the toString of the error. The full stack trace for these faults is available to end users in "exceptionStackTrace" of the report. But for cluster operators, if debug logging is not enabled, then for Dart only the message is logged, not the stack trace. In this scenario it's useful for the message to be more detailed.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful for the fault message to have some description of the underlying error: why did the worker fail, or why did the RPC call fail? This patch updates the fault messages to include the toString of the error.
The full stack trace for these faults is available to end users in "exceptionStackTrace" of the report. But for cluster operators, if debug logging is not enabled, then for Dart only the message is logged, not the stack trace. In this scenario it's useful for the message to be more detailed.