Upgrade Guice to 5.1.0

[Akshat-Jain]

Description

This PR upgrades Guice to 5.1.0 and fixes the failing tests.

---

This PR has:

• been self-reviewed.
• added documentation for new or modified features or behaviors.
• a release note entry in the PR description.
• added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
• added or updated version, license, or notice information in licenses.yaml
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
• added integration tests.
• been tested in a test Druid cluster.

[kfaraz]

Thanks for the changes, @Akshat-Jain !
Most of the stuff looks good. The ExceptionMatcher is very useful for readability of tests.

I have a couple of questions:

• Do we not need the guice-multibindings dependency anymore? Where was it being used? Is it now coming packaged inside the other guice dependencies?
• Are the changes made to DruidCoreInjectorBuilder required in this PR? I would prefer it if we tackled that improvement separately.

[Akshat-Jain]

@kfaraz Thanks for the review!

Thanks for the changes, @Akshat-Jain ! Most of the stuff looks good. The ExceptionMatcher is very useful for readability of tests.

Credits to @imply-cheddar for the original changes! 😄

I have a couple of questions:

• Do we not need the guice-multibindings dependency anymore? Where was it being used? Is it now coming packaged inside the other guice dependencies?

Yeah. Since Guice 4.2, multibindings support has moved to Guice core. Reference: https://github.com/google/guice/wiki/Multibindings

• Are the changes made to DruidCoreInjectorBuilder required in this PR? I would prefer it if we tackled that improvement separately.

Have reverted those changes.

[kgyrtkirk]

+1 (pending tests)

[capistrant]

Looks good to me. Small request for a javadoc to describe the new ExceptionMatcher class. Will when passing CI