Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Batch19 SQL aggregation functions #17658

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

writer-jill
Copy link
Contributor

@writer-jill writer-jill commented Jan 23, 2025

Add examples to the sql-functions.md page.

Updates the following SQL aggregation functions:

  • BLOOM_FILTER
  • BLOOM_FILTER_TEST
  • DECODE_BASE64_COMPLEX
  • DECODE_BASE64_UTF8

This PR has:

  • been self-reviewed.

@writer-jill writer-jill changed the title Batch19 SQL aggregation functions [docs] Batch19 SQL aggregation functions Jan 24, 2025
docs/querying/sql-functions.md Outdated Show resolved Hide resolved
docs/querying/sql-functions.md Outdated Show resolved Hide resolved
docs/querying/sql-functions.md Outdated Show resolved Hide resolved
docs/querying/sql-functions.md Outdated Show resolved Hide resolved
writer-jill and others added 2 commits January 27, 2025 14:00
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
@writer-jill writer-jill requested a review from vtlim January 27, 2025 14:19

</details>

[Learn more](sql-aggregations.md)
Copy link
Member

@vtlim vtlim Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this link to scalar other

Comment on lines +1287 to +1289
`numEntries` specifies the maximum number of distinct values before the false positive rate increases.

* **Syntax:** `BLOOM_FILTER(expr, numEntries)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`numEntries` specifies the maximum number of distinct values before the false positive rate increases.
* **Syntax:** `BLOOM_FILTER(expr, numEntries)`
* **Syntax:** `BLOOM_FILTER(expr, numEntries)`
`numEntries` specifies the maximum number of distinct values before the false positive rate increases.

@@ -1282,21 +1282,74 @@ Returns the following:

## BLOOM_FILTER

Computes a Bloom filter from values produced by the specified expression.
Computes a [bloom filter](../development/extensions-core/bloom-filter.md) from values provided in an expression.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Bloom is a name so all instances of this should be capitalized

- `druid-tdigestsketch`: `tDigestSketch`

* **Syntax:** `DECODE_BASE64_COMPLEX(dataType, expr)`
* **Function type:** Scalar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Function type:** Scalar
* **Function type:** Scalar, other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants