Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipm: change from log4go to dubbo getty default log lib #86

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

Lvnszn
Copy link

@Lvnszn Lvnszn commented Dec 8, 2021

What this PR does:
Change from log4go to dubbogo log lib
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #86 (de68c22) into master (66e083f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   69.14%   69.14%           
=======================================
  Files           8        8           
  Lines        1439     1439           
=======================================
  Hits          995      995           
  Misses        348      348           
  Partials       96       96           
Impacted Files Coverage Δ
logger.go 16.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e083f...de68c22. Read the comment docs.

@AlexStocks
Copy link

这个库是 dubb-go 的底层库,所以不要引用 dubbo-go 的库, "dubbo.apache.org/dubbo-go/v3/common/logger" 这种形式的东西去掉,否则很容易造成循环依赖。你可以看下 “https://github.com/dubbogo/gost/blob/master/log/logger.go” 是否满足你的需要,如果不满足,可以去改进 dubbo-go 和 dubbo-getty 的共同的基础库 gost

@Lvnszn Lvnszn changed the title Ipm: change from log4go to dubbogo log lib Ipm: change from log4go to dubbo getty default log lib Dec 15, 2021
@Lvnszn
Copy link
Author

Lvnszn commented Dec 15, 2021

这个库是 dubb-go 的底层库,所以不要引用 dubbo-go 的库, "dubbo.apache.org/dubbo-go/v3/common/logger" 这种形式的东西去掉,否则很容易造成循环依赖。你可以看下 “https://github.com/dubbogo/gost/blob/master/log/logger.go” 是否满足你的需要,如果不满足,可以去改进 dubbo-go 和 dubbo-getty 的共同的基础库 gost

调整了一版本,用了getty里面的logger,只要不注入logger的实例会用默认的zap log。PLAT @AlexStocks

@AlexStocks AlexStocks merged commit 76136d0 into apache:master Dec 20, 2021
@Lvnszn Lvnszn deleted the feature/log branch December 20, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants