Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: taskPool will execute task when session was nil #91

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Lvnszn
Copy link

@Lvnszn Lvnszn commented Jan 7, 2022

What this PR does:
First task was be added into task pool, then session will be set to nil with connection interrupted and task was executed by goroutine will lead to panic.
Which issue(s) this PR fixes:

Fixes #88

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #91 (d25d2a8) into master (76136d0) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   69.14%   69.09%   -0.06%     
==========================================
  Files           8        8              
  Lines        1439     1443       +4     
==========================================
+ Hits          995      997       +2     
- Misses        348      349       +1     
- Partials       96       97       +1     
Impacted Files Coverage Δ
session.go 69.66% <50.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76136d0...d25d2a8. Read the comment docs.

@AlexStocks AlexStocks merged commit 292995d into apache:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getty encounters broken pipeline issue
5 participants