Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: date nil bug #102

Merged
merged 15 commits into from
Jul 24, 2019
Merged

Fix: date nil bug #102

merged 15 commits into from
Jul 24, 2019

Conversation

aliiohs
Copy link
Member

@aliiohs aliiohs commented Jul 18, 2019

What this PR does:
#90
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@wongoo wongoo changed the title Feature/fix date nil bug Fix: date nil bug Jul 18, 2019
date_test.go Outdated Show resolved Hide resolved
date.go Show resolved Hide resolved
encode.go Outdated Show resolved Hide resolved
object.go Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Jul 22, 2019

@aliiohs u can use func SetValue instead to set value, which will match the target and source type.

codec.go Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Jul 24, 2019

LGTM, great thanks to @aliiohs for the hard work~

@wongoo wongoo merged commit 9dcc3c0 into apache:master Jul 24, 2019
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants