fix issue 149 - embed struct #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micln
commented
Feb 22, 2020
|
after reconsidering， I suggest not try to ignore fields when not find，which can be submitted in another PR， keep this pr focused. @micln |
|
@fangyincheng review this pr when having time |
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
* fix issue 149 - embed struct * remove serialUID * mapping extends to all feilds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #149
Special notes for your reviewer:
how it works ?
findname will find field in all fields first, then find field in anonymous field, so that it can compatibility preview version
Does this PR introduce a user-facing change?: