Ftr: add collection support according to java implementation #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls update readme about this feature. |
|
@hxmhlt @fangyincheng pls own this pr. |
fangyincheng
reviewed
Mar 8, 2020
java_collection_test.go
Outdated
| return "java.util.HashSet" | ||
| } | ||
|
|
||
| func init() { |
aliiohs
reviewed
Mar 13, 2020
| SetCollectionSerialize(&JavaHashSet{}) | ||
| } | ||
|
|
||
| type JavaHashSet struct { |
There was a problem hiding this comment.
在gost中我们已经实现了正在的hashset，这个是否可以复用？
There was a problem hiding this comment.
这边设计设想是依赖接口，集合的具体实现开放给用户或外部来实现；这里只是一个实现了接口的简单例子
There was a problem hiding this comment.
我到不觉得是例子，一旦加入实际上则成为了标准，用户也不会另外实现。 所以我也建议尝试复用gost里面的hashset。
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 66.45% 66.17% -0.29%
==========================================
Files 21 22 +1
Lines 2573 2652 +79
==========================================
+ Hits 1710 1755 +45
- Misses 667 691 +24
- Partials 196 206 +10
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Mar 14, 2020
AlexStocks
reviewed
Mar 14, 2020
|
LGTM |
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
Ftr: add collection support according to java implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for java collections such as HashSet
Collections are encoded through Serializer and decoded as list with regard of its type (collection types are encoded as the type of FixedTypedList in java impl of hessian).
The collection struct implements are open for users, see what java_collection_test.go does.
Issue #122
Special notes for your reviewer:
To reach the feature, code of method "readTypedList" in list.go also changes a little.
Related test codes of java side have also been added, see the last methods in TestCustomDecode.java & TestCustomReply.java
Does this PR introduce a user-facing change?:
Users need to implements collection structs and set them into go-hessian2, examples can be found in java_collection_test.go