-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: eunm encode in request get error #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pls add an ut. |
zouyx
reviewed
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ut for this PR?
zouyx
reviewed
Jun 18, 2020
AlexStocks
approved these changes
Jun 19, 2020
zouyx
approved these changes
Jun 19, 2020
wongoo
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wongoo
added a commit
that referenced
this pull request
Jun 23, 2020
* add license checker (#175) * add release note for v1.5.0 (#178) Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> * Imp: cache in reflection (#179) * benchmark result * use cache in findField * encode benchmark * call field() once * remove version * fix import sync * cache in registerPOJO * add json bench result * prune unneccessary rtype.Field(index) * cache comment * rename cache * switch to if * remove return value name * findFieldWithCache * remove if check when fieldStruct is nil Co-authored-by: 望哥 <gelnyang@163.com> * update dependency * rename serialize arg name * Create .asf.yaml * 优化hessian解码string性能,提升54% * optimize code. * optimize code. * fix code review. * optimize codes. * optimize cods. * optimize code. * update license * go.sum * ci go version * testify -> 1.4.0 * testcase * travis.yml * decode value before reflect find * setvalue * decode nilPtr to nilPtr * fix get attachment lost nil key * manually import package * add ToMapStringString unit test * rename test function name with issue * setmap * support for decode emoji. * refactor code * add unit test. * add unit tests. * refactor tests. * Update travis/main.sh (#200) - Remove duplicate key 'webhooks' - Key 'matrix' is an alias for `jobs`, using `jobs` - Specify the os and dist explicitly * Mod: modify * Code format (#199) * .gitignore * code clean * code clean * remove length check * Fix: comments * Fix: format package * Fix #181: float32 accuracy issue (#196) * Fix #181: float32 accuracy issue * Fix go fmt failure * Add the unit test case for Issue181 * Add encFloat32 in double.go to encode float32 type - Call encFloat32 to encode float32 while encoding - Add unit test case to test float32 encoding * Improve encFloat32 of double.go * Fix git fmt failure * add release note for v1.6.0 (#202) * add release note for v1.5.1 * add release note for v1.5.1 * add notice * update notice * =fix release note for v1.6.0 * Fix: eunm encode in request get error (#203) * fix bug: eunm encode in request get error * fix mod * add ut * remove go.mod 1.13 to fix the ci Co-authored-by: Joe Zou <joezou@apache.org> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: huiren <zhrlnt@gmail.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: zonghaishang <yiji@apache.org> Co-authored-by: fangyincheng <fangyc666@gmail.com> Co-authored-by: champly <champly@outlook.com> Co-authored-by: wilson chen <willson.chenwx@gmail.com> Co-authored-by: fangyincheng <fangyincheng@sina.com> Co-authored-by: gaoxinge <gaoxx5@gmail.com> Co-authored-by: panty <pantianying@gmail.com>
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
* fix bug: eunm encode in request get error * fix mod * add ut * remove go.mod 1.13 to fix the ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
fix the bug when eunm encode in request。
Which issue(s) this PR fixes:
#187